http,http2: speed up header validation and write coalescing by anonrig · Pull Request #65332 · nodejs/node · GitHub
Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/_http_client.js
33 changes: 21 additions & 12 deletions lib/_http_common.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,18 @@
'use strict';

const {
ArrayIsArray,
MathMin,
Symbol,
Uint8Array,
} = primordials;
const { setImmediate } = require('timers');

const { methods, allMethods, HTTPParser } = internalBinding('http_parser');
const {
methods,
allMethods,
HTTPParser,
} = internalBinding('http_parser');
const { getOptionValue } = require('internal/options');
const insecureHTTPParser = getOptionValue('--insecure-http-parser');

Expand Down Expand Up @@ -105,13 +110,17 @@ function parserOnHeadersComplete(versionMajor, versionMinor, headers, method,
incoming.url = url;
incoming.upgrade = upgrade;

let n = headers.length;
if (headers !== undefined && !ArrayIsArray(headers)) {
incoming._setNativeHeaders(headers, parser.maxHeaderPairs);
} else {
let n = headers.length;

// If parser.maxHeaderPairs <= 0 assume that there's no limit.
if (parser.maxHeaderPairs > 0)
n = MathMin(n, parser.maxHeaderPairs);
// If parser.maxHeaderPairs <= 0 assume that there's no limit.
if (parser.maxHeaderPairs > 0)
n = MathMin(n, parser.maxHeaderPairs);

incoming._addHeaderLines(headers, n);
incoming._addHeaderLines(headers, n);
}

if (typeof method === 'number') {
// server only
Expand Down Expand Up @@ -241,14 +250,14 @@ const validTokenChars = new Uint8Array([
* @returns {boolean}
*/
function checkIsHttpToken(val) {
if (val.length >= 10) {
const len = val.length;
if (len === 0) return false;
// Table is faster for short names (Connection, Keep-Alive). V8's regex
// wins once the name is longer than ~10 bytes (Content-Length, etc.).
if (len > 10)
return tokenRegExp.test(val);
}

if (val.length === 0) return false;

// Use lookup table for short strings, regex for longer ones
for (let i = 0; i < val.length; i++) {
for (let i = 0; i < len; i++) {
if (!validTokenChars[val.charCodeAt(i)]) {
return false;
}
Expand Down
143 changes: 143 additions & 0 deletions lib/_http_incoming.js
Loading
Loading