{{ message }}
test: simplify timers interval rejection assertion - #65322
Merged
nodejs-github-bot merged 1 commit intoAug 23, 2026
Merged
Conversation
Signed-off-by: HoonDongKang <d159123@naver.com>
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Aug 16, 2026
lpinca
added
the
request-ci
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
added
request-ci
Collaborator
trivikr
added
commit-queue
Collaborator
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace a rejection-only
try/catchblock intest-timers-interval-promisified.jswithassert.rejects().This simplifies the abort rejection test by verifying both the rejection and
the expected error shape in a single assertion, improving readability without
changing the tested behavior.
Refs:
Tests:
./node test/parallel/test-timers-interval-promisified.jstools/test.py test/parallel/test-timers-interval-promisified.js