tools: fix the list of globals in ESLint config files by aduh95 · Pull Request #65281 · nodejs/node · GitHub
Skip to content

tools: fix the list of globals in ESLint config files - #65281

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:fix-globals
Aug 23, 2026
Merged

tools: fix the list of globals in ESLint config files#65281
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:fix-globals

Conversation

@aduh95

@aduh95 aduh95 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

As reported in #64894 (comment), we were missing some entries. I also took the liberty of reordering the list in ASCII order as there were only a few items out of order.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Aug 14, 2026
@aduh95 aduh95 mentioned this pull request Aug 14, 2026
Closed
1 task done
MikeMcC399
MikeMcC399 reviewed Aug 14, 2026
View reviewed changes
Comment thread lib/eslint.config_partial.mjs Outdated
MikeMcC399
MikeMcC399 reviewed Aug 14, 2026
View reviewed changes
Comment thread lib/eslint.config_partial.mjs Outdated
MikeMcC399
MikeMcC399 reviewed Aug 14, 2026
View reviewed changes
Comment thread lib/eslint.config_partial.mjs Outdated
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 14, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 16, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 16, 2026

Copy link
Copy Markdown
Collaborator

@trivikr

trivikr commented Aug 21, 2026

Copy link
Copy Markdown
Member

This needs a rebase

@trivikr trivikr removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Aug 21, 2026
@aduh95
tools: fix the list of globals in ESLint config files
92cabd4 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Aug 23, 2026
@aduh95 @MikeMcC399
squash! fix typo
c6d8685 
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@aduh95
aduh95 merged commit 220ee76 into nodejs:main Aug 23, 2026
14 checks passed
@aduh95

aduh95 commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

@aduh95
aduh95 deleted the fix-globals branch August 23, 2026 15:09
aduh95 added a commit that referenced this pull request Aug 29, 2026
@aduh95
tools: fix the list of globals in ESLint config files
cd933a0 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65281
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Merged
aduh95 added a commit that referenced this pull request Sep 15, 2026
@aduh95
tools: fix the list of globals in ESLint config files
19779f1 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65281
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MikeMcC399 MikeMcC399 MikeMcC399 left review comments
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95 @nodejs-github-bot @trivikr @lpinca @anonrig @cjihrig @legendecas @MikeMcC399