{{ message }}
buffer: prevent string write offset overflow - #65043
Merged
nodejs-github-bot merged 1 commit intoAug 19, 2026
Merged
Conversation
Reject offsets outside the destination buffer before subtracting from its length in SlowWriteString. Normalize wrapper arguments once so validated values reach the native binding. Signed-off-by: Matteo Collina <hello@matteocollina.com>
nodejs-github-bot
added
buffer
ronag
approved these changes
Aug 6, 2026
ronag
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
ronag
added
the
request-ci
github-actions
Bot
removed
the
request-ci
ronag
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
ronag
added
the
request-ci
Collaborator
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
mcollina
added
the
commit-queue
Collaborator
nodejs-github-bot
removed
the
commit-queue
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Reject offsets outside the destination buffer before subtracting from its length in SlowWriteString. Normalize wrapper arguments once so validated values reach the native binding. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65043 Reviewed-By: Robert Nagy <ronagy@icloud.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Reject offsets outside the destination buffer before subtracting from its length in SlowWriteString. Normalize wrapper arguments once so validated values reach the native binding. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65043 Reviewed-By: Robert Nagy <ronagy@icloud.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
Reject offsets outside the destination buffer before subtracting from its length in SlowWriteString. Normalize wrapper arguments once so validated values reach the native binding. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65043 Reviewed-By: Robert Nagy <ronagy@icloud.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 7, 2026
Reject offsets outside the destination buffer before subtracting from its length in SlowWriteString. Normalize wrapper arguments once so validated values reach the native binding. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65043 Reviewed-By: Robert Nagy <ronagy@icloud.com>
aduh95
pushed a commit
that referenced
this pull request
Sep 7, 2026
Reject offsets outside the destination buffer before subtracting from its length in SlowWriteString. Normalize wrapper arguments once so validated values reach the native binding. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #65043 Reviewed-By: Robert Nagy <ronagy@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject offsets outside the destination buffer before subtracting from its length in SlowWriteString. Normalize wrapper arguments once so validated values reach the native binding.