util: fix formatting of functions returned from getters by gibson042 · Pull Request #64839 · nodejs/node · GitHub
Skip to content

util: fix formatting of functions returned from getters - #64839

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
gibson042:gh-64838-inspect-function-from-getter
Aug 22, 2026
Merged

util: fix formatting of functions returned from getters#64839
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
gibson042:gh-64838-inspect-function-from-getter

Conversation

@gibson042

@gibson042 gibson042 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Fixes: #64838

@gibson042
util: fix formatting of functions returned from getters
5423679 
Fixes: nodejs#64838
Signed-off-by: Richard Gibson <richard.gibson@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jul 30, 2026
@codecov

codecov Bot commented Jul 30, 2026 •
edited
Loading

Copy link
Copy Markdown

avivkeller
avivkeller approved these changes Jul 30, 2026
View reviewed changes

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from linting, LGTM

@bakkot bakkot mentioned this pull request Jul 31, 2026
Closed
@avivkeller avivkeller added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 1, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 1, 2026
@nodejs-github-bot

This comment was marked as resolved.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75539/

@trivikr trivikr added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit a48e33f into nodejs:main Aug 22, 2026
88 of 90 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 22, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@gibson042 @aduh95
util: fix formatting of functions returned from getters
95aa25c 
Fixes: #64838
Signed-off-by: Richard Gibson <richard.gibson@gmail.com>
PR-URL: #64839
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@gibson042 @aduh95
util: fix formatting of functions returned from getters
eb1ebbb 
Fixes: #64838
Signed-off-by: Richard Gibson <richard.gibson@gmail.com>
PR-URL: #64839
Reviewed-By: Aviv Keller <me@aviv.sh>
@aduh95 aduh95 mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@gibson042 @aduh95
util: fix formatting of functions returned from getters
8689612 
Fixes: #64838
Signed-off-by: Richard Gibson <richard.gibson@gmail.com>
PR-URL: #64839
Reviewed-By: Aviv Keller <me@aviv.sh>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Open
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@gibson042 @aduh95
util: fix formatting of functions returned from getters
10e2603 
Fixes: #64838
Signed-off-by: Richard Gibson <richard.gibson@gmail.com>
PR-URL: #64839
Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@gibson042 @aduh95
util: fix formatting of functions returned from getters
10cbb6d 
Fixes: #64838
Signed-off-by: Richard Gibson <richard.gibson@gmail.com>
PR-URL: #64839
Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

util.inspect fails to represent a function returned from a getter

4 participants

@gibson042 @nodejs-github-bot @avivkeller @trivikr