{{ message }}
src: expose Windows-only fs open flags - #64775
Merged
Merged
Conversation
nodejs-github-bot
added
c++
PickBas
force-pushed
the
win-new-constants
branch
from
July 27, 2026 07:43
3fb62df to
23c32f5
Compare
avivkeller
approved these changes
Jul 27, 2026
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com>
PickBas
force-pushed
the
win-new-constants
branch
from
August 6, 2026 11:36
23c32f5 to
cee62bb
Compare
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
StefanStojanovic
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
9 tasks
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com> PR-URL: #64775 Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com> PR-URL: #64775 Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
Signed-off-by: Kirill Saied <sayed.kirill@gmail.com> PR-URL: #64775 Reviewed-By: Aviv Keller <me@aviv.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src: expose Windows-only fs open flags
libuv honors several Windows-only open flags but Node never exported the constants, so they were unreachable from
fs.open(). ExposeUV_FS_O_TEMPORARY,UV_FS_O_SHORT_LIVED,UV_FS_O_SEQUENTIALandUV_FS_O_RANDOMunder theUV_FS_O_prefix, matching the existingUV_FS_O_FILEMAP. They are0on non-Windows platforms.UV_FS_O_TEMPORARYdeletes the file when the last handle closes,UV_FS_O_SHORT_LIVEDavoids flushing a throwaway file to disk, andUV_FS_O_SEQUENTIAL/UV_FS_O_RANDOMhint the access pattern to optimize caching.