{{ message }}
test: increase timeout in probe-failure-hang-during-evaluate - #64719
Merged
Conversation
On slower CI machines, the probed process may take longer time to bootstrap and establish connection to. Increase the timeout so it's more likely to finish testing before timing out. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
added
needs-ci
avivkeller
approved these changes
Jul 24, 2026
lpinca
approved these changes
Jul 24, 2026
joyeecheung
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
legendecas
approved these changes
Jul 24, 2026
joyeecheung
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
On slower CI machines, the probed process may take longer time to bootstrap and establish connection to. Increase the timeout so it's more likely to finish testing before timing out. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #64719 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-07-24.md Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
On slower CI machines, the probed process may take longer time to bootstrap and establish connection to. Increase the timeout so it's more likely to finish testing before timing out. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #64719 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-07-24.md Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
On slower CI machines, the probed process may take longer time to bootstrap and establish connection to. Increase the timeout so it's more likely to finish testing before timing out. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #64719 Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-07-24.md Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On slower CI machines, the probed process may take longer time to bootstrap and establish connection to. Increase the timeout so it's more likely to finish testing before timing out.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-07-24.md
Also see the logs of https://ci.nodejs.org/job/node-test-commit-smartos/nodes=smartos23-x64/66791/consoleFull where other probe tests take ~1s to finish end to end, and the logs of flaked probe-failure-hang-during-evaluate showed that it timing out before finishing testing.