test: resolve flaky repl test by avivkeller · Pull Request #64594 · nodejs/node · GitHub
Skip to content

test: resolve flaky repl test - #64594

Closed
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:resolve-repl-flaky
Closed

avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:resolve-repl-flaky

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Post 4f844f4 (#64034), there's a small chance that test/parallel/test-repl-user-error-handler.js will fail, since it treats our now asynchronous REPL as synchronous.

Based on the in-progress https://ci.nodejs.org/job/node-stress-single-test/800/, the flake rate is <1.5% (1 failure in 70 runs).

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Jul 19, 2026
@avivkeller avivkeller added flaky-test Issues and PRs involving tests that fail intermittently in CI. repl Issues and PRs related to the REPL subsystem. labels Jul 19, 2026
@avivkeller
avivkeller marked this pull request as draft July 19, 2026 06:43
@avivkeller

Copy link
Copy Markdown
Member Author

@avivkeller avivkeller closed this Jul 19, 2026
@codecov

codecov Bot commented Jul 19, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants