child_process: keep SIGWINCH from killing on Win by PickBas · Pull Request #64510 · nodejs/node · GitHub
Skip to content

child_process: keep SIGWINCH from killing on Win - #64510

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:issue-64324
Aug 21, 2026
Merged

child_process: keep SIGWINCH from killing on Win#64510
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
JaneaSystems:issue-64324

Conversation

@PickBas

@PickBas PickBas commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

child_process: keep SIGWINCH from killing on Win

On Windows, ProcessWrap::Kill coerced any signal outside {SIGKILL, SIGTERM, SIGINT, SIGQUIT, 0} to SIGKILL. This wrongly terminated a process on kill('SIGWINCH'), a non-terminal signal.

SIGWINCH now skips the coercion and reaches libuv, which returns UV_ENOSYS, surfaced as an ENOSYS error in JS, leaving the target process alive.

Fixes: #64324

@PickBas
child_process: keep SIGWINCH from killing on Win
9d89021 
Fixes: nodejs#64324
Signed-off-by: PickBas <sayed.kirill@gmail.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76038/

@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 9677349 into nodejs:main Aug 21, 2026
83 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 21, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@PickBas @aduh95
child_process: keep SIGWINCH from killing on Win
e78eded 
Fixes: #64324
Signed-off-by: PickBas <sayed.kirill@gmail.com>
PR-URL: #64510
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@PickBas @aduh95
child_process: keep SIGWINCH from killing on Win
21655dc 
Fixes: #64324
Signed-off-by: PickBas <sayed.kirill@gmail.com>
PR-URL: #64510
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@PickBas @aduh95
child_process: keep SIGWINCH from killing on Win
26ad6b0 
Fixes: #64324
Signed-off-by: PickBas <sayed.kirill@gmail.com>
PR-URL: #64510
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Open
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@PickBas @aduh95
child_process: keep SIGWINCH from killing on Win
31b5f6c 
Fixes: #64324
Signed-off-by: PickBas <sayed.kirill@gmail.com>
PR-URL: #64510
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@PickBas @aduh95
child_process: keep SIGWINCH from killing on Win
33d0c7d 
Fixes: #64324
Signed-off-by: PickBas <sayed.kirill@gmail.com>
PR-URL: #64510
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

subprocess.kill('SIGWINCH') forcefully terminates subprocesses on Windows

4 participants

@PickBas @nodejs-github-bot @StefanStojanovic @trivikr