{{ message }}
quic: fix potential crash from unobserved closed#64134
Open
pimterry wants to merge 1 commit into
Open
Conversation
Collaborator
nodejs-github-bot
added
needs-ci
Signed-off-by: Tim Perry <pimterry@gmail.com>
pimterry
force-pushed
the
fix-quic-closed-crash
branch
from
fa6eb73 to
4c10f54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is independent of the other "split up the h3-split PR" PRs I've just opened - not related to that stream, just something else I ran into)
This fixes a potential crash in QUIC generally. Currently if you don't listen to and handle errors from
session.closedsynchronously when the session opens (I think doing so is quite uncommon) then by default any remote client can crash the server. Tiny independent fix.See the test for a demo:
closedwasn't marked as handled, and so any error would trigger a unhandledRejection, which exits the process by default.