build: add manually-dispatched stress-test workflow by joyeecheung · Pull Request #64118 · nodejs/node · GitHub
Skip to content

build: add manually-dispatched stress-test workflow#64118

Open
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:stress-workflow
Open

build: add manually-dispatched stress-test workflow#64118
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:stress-workflow

Conversation

@joyeecheung

Copy link
Copy Markdown
Member

Add a GitHub action workflow that can be manually dispatched to stress-run tests on a PR/branch to verify flakiness.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Add a GitHub action workflow that can be manually dispatched to
stress-run tests on a PR/branch to verify flakiness.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 24, 2026
@joyeecheung joyeecheung changed the title tools: add manually-dispatched stress-test workflow build: add manually-dispatched stress-test workflow Jun 24, 2026
Comment thread .github/workflows/stress-test.yml
@joyeecheung joyeecheung added the review wanted PRs that need reviews. label Jun 25, 2026
@panva

panva commented Jun 25, 2026

Copy link
Copy Markdown
Member

How would I trigger this on a PR created from the contributor's fork?

@joyeecheung

joyeecheung commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

How would I trigger this on a PR created from the contributor's fork?

This version only allows triggering from a branch in the repo the workflow file is in - you could still do it from a PR, just that PR must come from a branch here (which also means you need to have write access here). If someone wants to make it work for a fork I think that can be a follow up, but be aware that allowing runs from forks can carry security risks, and to make this action useful there's an argument that allows arbitrary arguments to test.py.

I think for the best balance between usefulness v.s. safety it's better to only allow people with write access in this repo to test from a branch in this repo. If they want to run it from a fork, just use an action from that fork, but not from this repo. So to your question - pull that contributor's branch to your fork, and run that action from your fork.

@panva

panva commented Jun 25, 2026

Copy link
Copy Markdown
Member

Add a GitHub action workflow that can be manually dispatched to stress-run tests on a PR/branch to verify flakiness.

I only asked because of the description that specifically mentions PRs. I'm fine with the scope-as is.

@joyeecheung

joyeecheung commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project. review wanted PRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants