{{ message }}
vfs: read RealFSProvider files from open fd#64104
Open
trivikr wants to merge 2 commits into
Open
Conversation
Read RealFileHandle contents through the open file descriptor instead of reopening the original real path. This keeps already-open VFS file descriptors usable after the backing file is renamed. Use positioned reads so readFileSync() and readFile() preserve the handle's current offset. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
mcollina
reviewed
Jun 25, 2026
Member
There was a problem hiding this comment.
I don't understand this default size. It seems this is a bug waiting to happen.
If fstatSync does not return the size, this will be initialized by default at 8KB. Can that happen? Why 8KB?
Member
Author
There was a problem hiding this comment.
8192 is the default in fs
Lines 582 to 585 in 4f177f1
Member
Author
There was a problem hiding this comment.
It does introduce a bug where zero-size files were concatenated at 8192 bytes.
It was fixed in 2cef149 (this PR) with a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64103
RealFileHandle.readFileSync()andreadFile()previously reopened theoriginal real path. If the backing file was renamed after the VFS fd was opened,
fs.readFileSync(fd, ...)failed withENOENT.This changes
RealFileHandleto read through the already-open real fd usingpositioned reads. That matches native filesystem behavior for renamed open files
and preserves the handle's current offset.
The async
readFile()path continues to use asyncstat()andread()operations.
Assisted-by: openai:gpt-5.5