debugger: wait for initial pause output after run by inoway46 · Pull Request #64042 · nodejs/node · GitHub
Skip to content

debugger: wait for initial pause output after run#64042

Closed
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:debugger-run-restart-pause-sync
Closed

debugger: wait for initial pause output after run#64042
inoway46 wants to merge 1 commit into
nodejs:mainfrom
inoway46:debugger-run-restart-pause-sync

Conversation

@inoway46

@inoway46 inoway46 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Based on: #64005 (comment)

run / restart could resolve after Runtime.runIfWaitingForDebugger() but before the async Debugger.paused output path printed the initial break ... in ... message.

This updates run / restart to wait for that initial pause output before resolving.

Target flaky tests

Testing

./tools/test.py -p actions parallel/test-debugger-run-restart-init parallel/test-debugger-run-after-quit-restart parallel/test-debugger-exceptions parallel/test-debugger-preserve-breaks parallel/test-debugger-restart-message
./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart parallel/test-debugger-exceptions

Refs: #64005, #61762

Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Jun 21, 2026
@inoway46 inoway46 marked this pull request as ready for review June 21, 2026 04:35
@inoway46 inoway46 marked this pull request as draft June 21, 2026 04:40
@inoway46

Copy link
Copy Markdown
Contributor Author

@trivikr

trivikr commented Jun 22, 2026

Copy link
Copy Markdown
Member

We just landed #63969. This PR can be rebased and made ready for review.

@inoway46

Copy link
Copy Markdown
Contributor Author

@inoway46 inoway46 closed this Jun 23, 2026
@inoway46 inoway46 deleted the debugger-run-restart-pause-sync branch June 23, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants