{{ message }}
src: merge CreateEnvironment() overloads#63596
Merged
nodejs-github-bot merged 1 commit intoJun 4, 2026
Merged
Conversation
addaleax
added
c++
addaleax
force-pushed
the
abi-break-CreateEnvironment
branch
from
23c5506 to
37016f3
Compare
addaleax
changed the title
CreateEnvironment() implementationsCreateEnvironment() overloads
legendecas
approved these changes
May 27, 2026
Member
|
The linter error should be fixed with #63598 landed on the main branch. Would you mind rebasing on top of the main branch? |
API-compatible, but ABI-breaking, so done separately from the original 3090def. Signed-off-by: Anna Henningsen <anna@addaleax.net>
Member
Author
|
@legendecas Thank you, done! |
addaleax
force-pushed
the
abi-break-CreateEnvironment
branch
from
37016f3 to
a21167c
Compare
legendecas
approved these changes
May 27, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Member
Author
|
@nodejs/tsc This is technically semver-major because of the ABI change so needs another TSC approval |
anonrig
approved these changes
Jun 3, 2026
gurgunday
added
the
author ready
addaleax
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API-compatible, but ABI-breaking, so done separately from the original 3090def.