{{ message }}
src: fix ContextifyContext property definer interception result#63549
Merged
Conversation
nodejs-github-bot
added
c++
Signed-off-by: Chengzhong Wu <legendecas@gmail.com>
legendecas
force-pushed
the
vm-intercept-52634
branch
from
8baf29f to
3fb03c6
Compare
addaleax
approved these changes
May 26, 2026
addaleax
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
aduh95
approved these changes
May 27, 2026
Collaborator
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
Renegade334
added
the
baking-for-lts
This was referenced Jun 3, 2026
legendecas
added a commit
to legendecas/node
that referenced
this pull request
Jun 22, 2026
This fixes a long-standing issue that `ContextifyContext::PropertyDefinerCallback` incorrectly copies the `const PropertyDescriptor& desc`, assigning value to be `undefined` when the no value present on the `PropertyDescriptor`. This is revealed after nodejs#63549 because returning `kYes` tells V8 that the definer handled it, and V8 no longer fixes it up. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
legendecas
added a commit
to legendecas/node
that referenced
this pull request
Jun 22, 2026
This fixes a long-standing issue that `ContextifyContext::PropertyDefinerCallback` incorrectly copies the `const PropertyDescriptor& desc`, assigning value to be `undefined` when no value present on the `PropertyDescriptor`. This is revealed after nodejs#63549 because returning `kYes` tells V8 that the definer handled it, and V8 no longer fixes it up. Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
luanmuniz
pushed a commit
to luanmuniz/node
that referenced
this pull request
Jun 25, 2026
Signed-off-by: Brian Meek <55990082+brianathere@users.noreply.github.com> PR-URL: nodejs#63742 Fixes: nodejs#63739 Refs: nodejs#63549 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes that when defining a property, a definer callback
like a proxy handler would be invoked twice when the property
is writable.
Fixes: #52634