{{ message }}
streams: remove unnecessary check#63030
Merged
Merged
Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
remove-needless-check
branch
from
491fa52 to
cb5d3a5
Compare
lpinca
approved these changes
Apr 29, 2026
jasnell
approved these changes
May 4, 2026
jasnell
approved these changes
May 4, 2026
trivikr
approved these changes
May 5, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gurgunday
approved these changes
May 5, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
anonrig
approved these changes
May 11, 2026
Collaborator
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
aduh95
added a commit
that referenced
this pull request
May 19, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
added a commit
that referenced
this pull request
May 19, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
added a commit
that referenced
this pull request
May 23, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#63030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95
added a commit
that referenced
this pull request
Jun 18, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63030 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+sizecoerces the a number, so there's no case where itstypeofwouldn't be anumber.Also, keep a reference to the original
sizeto return in theRangeErrorfor better UX.