{{ message }}
Open
Conversation
nodejs-github-bot
added
build
avivkeller
added
wip
Member
Author
There was a problem hiding this comment.
Pull request overview
Updates Node.js doc build configuration to experiment with the redesigned documentation output by switching doc-kit templates away from the legacy “all-in-one HTML” generation.
Changes:
- Switch doc-kit HTML generation template from
legacy-html-alltoweb(Makefile + Windows build). - Stop declaring
out/doc/api/all.htmlas a required/produced doc artifact in thedoc-onlyMakefile target.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Makefile |
Uses the web doc-kit template and removes all.html from declared doc build outputs. |
vcbuild.bat |
Uses the web doc-kit template during Windows doc generation. |
Comments suppressed due to low confidence (1)
Makefile:838
- The comment above this doc generation rule still says it generates
all.html/all.json, butall.htmlis no longer a target/output in this rule. Please update the comment to match the new set of generated artifacts to avoid confusion for future maintainers.
# Generate all doc files (individual and all.html/all.json) in a single doc-kit call
# Using grouped targets (&:) so Make knows one command produces all outputs
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shouldn't change much from it's current form. Most changes will go in
doc-kit.test-make-docwas removed, since our new generator minifies the output HTML (so it's format is structurally inconsistent) and can't be easily parsed with the existing regular expressions.Furthermore, such tests are not needed due to our tests in doc-kit.