tools: lint new WPTRunner() paths for no duplicates by panva · Pull Request #61618 · nodejs/node · GitHub
Skip to content

tools: lint new WPTRunner() paths for no duplicates#61618

Closed
panva wants to merge 1 commit intonodejs:mainfrom
panva:wpt-lint-new-wpt-runner
Closed

tools: lint new WPTRunner() paths for no duplicates#61618
panva wants to merge 1 commit intonodejs:mainfrom
panva:wpt-lint-new-wpt-runner

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Feb 1, 2026

A lint rule to prevent future issues of duplicate wpt tests

Refs: #61617
Refs: #61316 (comment)

Local result:

➜  node git:(main) ✗ make lint-js    
Running JS linter...

/node/test/wpt/test-webidl.js
  6:30  error  WPTRunner path 'webidl' overlaps with 'webidl/ecmascript-binding/es-exceptions' in /node/test/wpt/test-domexception.js. One path is a subset of the other, which would run the same tests multiple times  node-core/no-duplicate-wpt-runner-paths

✖ 1 problem (1 error, 0 warnings)

@panva panva requested a review from aduh95 February 1, 2026 16:14
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Feb 1, 2026
@panva

This comment was marked as outdated.

@panva panva marked this pull request as ready for review February 4, 2026 10:35
@panva panva force-pushed the wpt-lint-new-wpt-runner branch from 0d1b013 to 48d2bfe Compare February 4, 2026 10:37
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 4, 2026

@panva panva closed this Mar 11, 2026
@panva panva deleted the wpt-lint-new-wpt-runner branch March 20, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants