{{ message }}
assert: fix loose deepEqual arrays with undefined and null failing#61587
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 1, 2026
Merged
Conversation
nodejs-github-bot
added
needs-ci
BridgeAR
force-pushed
the
BridgeAR/2026-01-30-fix-deep-equal
branch
from
3d8064f to
9d35d47
Compare
The comparison has to accept these as identical. Fixes: nodejs#61583
BridgeAR
force-pushed
the
BridgeAR/2026-01-30-fix-deep-equal
branch
from
9d35d47 to
225a1fd
Compare
MrJithil
approved these changes
Jan 30, 2026
cjihrig
approved these changes
Jan 30, 2026
anonrig
approved these changes
Jan 30, 2026
ljharb
approved these changes
Jan 30, 2026
UlisesGascon
approved these changes
Jan 31, 2026
atlowChemi
approved these changes
Jan 31, 2026
atlowChemi
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
atlowChemi
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
The comparison has to accept these as identical. Fixes: #61583 PR-URL: #61587 Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Feb 2, 2026
The comparison has to accept these as identical. Fixes: #61583 PR-URL: #61587 Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Feb 10, 2026
The comparison has to accept these as identical. Fixes: #61583 PR-URL: #61587 Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Feb 14, 2026
The comparison has to accept these as identical. Fixes: #61583 PR-URL: #61587 Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Feb 22, 2026
The comparison has to accept these as identical. Fixes: #61583 PR-URL: #61587 Reviewed-By: Jithil P Ponnan <jithil@outlook.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparison has to accept these as identical.
Fixes: #61583