test: delay writing the files only on macOS by lpinca · Pull Request #61532 · nodejs/node · GitHub
Skip to content

test: delay writing the files only on macOS#61532

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
lpinca:delay/writing-only-on-macos
Jan 28, 2026
Merged

test: delay writing the files only on macOS#61532
nodejs-github-bot merged 1 commit intonodejs:mainfrom
lpinca:delay/writing-only-on-macos

Conversation

@lpinca
Copy link
Copy Markdown
Member

@lpinca lpinca commented Jan 26, 2026

Refs: #60060

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 26, 2026
juanarbol
juanarbol approved these changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 26, 2026 •
edited
Loading

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 27, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 27, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71057/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 27, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71061/

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2026
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 28, 2026
@nodejs-github-bot nodejs-github-bot merged commit a9dd48f into nodejs:main Jan 28, 2026
79 of 81 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Jan 28, 2026

@lpinca lpinca deleted the delay/writing-only-on-macos branch January 28, 2026 17:43
aduh95 pushed a commit that referenced this pull request Jan 28, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
6fbb0b7 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@github-actions github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 3, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
99eb1a8 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 3, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
e4a7922 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@github-actions github-actions Bot mentioned this pull request Feb 3, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 6, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
0035f3f 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
65248d9 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 19, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
275d3dd 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
3261ee5 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 21, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
2419284 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
@aduh95 aduh95 mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
16c69f5 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 24, 2026
@lpinca @aduh95
test: delay writing the files only on macOS
5fba382 
Refs: #60060
PR-URL: #61532
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juanarbol juanarbol juanarbol approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lpinca @nodejs-github-bot @juanarbol @jakecastelli