{{ message }}
build,win: fix vs2022 compilation#61530
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jan 28, 2026
Merged
Conversation
StefanStojanovic
added
windows
cjihrig
approved these changes
Jan 26, 2026
lpinca
approved these changes
Jan 26, 2026
Contributor
Contributor
Author
You are right, I haven't noticed that. It is changed now. |
targos
approved these changes
Jan 27, 2026
richardlau
approved these changes
Jan 27, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
aduh95
pushed a commit
that referenced
this pull request
Jan 28, 2026
PR-URL: #61530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This was referenced Feb 5, 2026
MikeMcC399
pushed a commit
to MikeMcC399/node
that referenced
this pull request
Feb 15, 2026
PR-URL: nodejs#61530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This was referenced Feb 15, 2026
MikeMcC399
pushed a commit
to MikeMcC399/node
that referenced
this pull request
Feb 18, 2026
Backport-PR-URL: nodejs#61840 PR-URL: nodejs#61530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
MikeMcC399
pushed a commit
to MikeMcC399/node
that referenced
this pull request
Feb 23, 2026
Backport-PR-URL: nodejs#61840 PR-URL: nodejs#61530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
MikeMcC399
pushed a commit
to MikeMcC399/node
that referenced
this pull request
Feb 23, 2026
Backport-PR-URL: nodejs#61840 PR-URL: nodejs#61530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
MikeMcC399
pushed a commit
to MikeMcC399/node
that referenced
this pull request
Feb 23, 2026
PR-URL: nodejs#61530 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we added VS2026 support, by accident we broke VS2022 compilation if you have both VS2026 and VS2022 installed (eg, you had to provide the
vs2022parameter). This PR fixes that bug.