lib: use bracket notation instead of `startsWith/endsWith` for single char by kimtaejin3 · Pull Request #61500 · nodejs/node · GitHub
Skip to content

lib: use bracket notation instead of startsWith/endsWith for single char - #61500

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kimtaejin3:lib/use-bracket-notation-for-single-char
Aug 23, 2026
Merged

lib: use bracket notation instead of startsWith/endsWith for single char#61500
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
kimtaejin3:lib/use-bracket-notation-for-single-char

Conversation

@kimtaejin3

@kimtaejin3 kimtaejin3 commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

This PR avoids potential prototype pollution and improves performance by replacing method calls with
direct property access.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Jan 24, 2026
@codecov

codecov Bot commented Jan 24, 2026 •
edited
Loading

Copy link
Copy Markdown

@kimtaejin3 kimtaejin3 changed the title lib: use bracket notation instead of startsWith/endsWith for single char lib: use bracket notation instead of startsWith/endsWith for single char Jan 24, 2026
@kimtaejin3

kimtaejin3 commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

@anonrig Could you please check the progress of this PR? It looks like it might be stuck after approval.

@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@ljharb ljharb added never-stale Issues and PRs exempt from automated stale handling. and removed stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. labels Jul 29, 2026
@trivikr
trivikr force-pushed the lib/use-bracket-notation-for-single-char branch from d6f31dc to fb03a1e Compare August 21, 2026 00:05
@trivikr trivikr added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed never-stale Issues and PRs exempt from automated stale handling. labels Aug 21, 2026
@trivikr trivikr added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 21, 2026
@trivikr

trivikr commented Aug 21, 2026

Copy link
Copy Markdown
Member

@kimtaejin3 Can you please sign the first commit and force push?

It's required as per updated instructions

Your commit must contain the Signed-off-by line with your name and email address as an acknowledgement that you agree to the Developer Certificate of Origin

@trivikr trivikr removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 21, 2026
@kimtaejin3
lib: use bracket notation instead of startsWith/endsWith for single char
5355e9f 
Signed-off-by: Taejin Kim <rlaxowls1316@naver.com>
@kimtaejin3
kimtaejin3 force-pushed the lib/use-bracket-notation-for-single-char branch from fb03a1e to 5355e9f Compare August 21, 2026 06:44
@trivikr trivikr added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 21, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76242/

@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 2df4ce7 into nodejs:main Aug 23, 2026
76 checks passed
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@kimtaejin3 @aduh95
lib: use bracket notation instead of startsWith/endsWith for single char
83c0a05 
Signed-off-by: Taejin Kim <rlaxowls1316@naver.com>
PR-URL: #61500
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@kimtaejin3 @aduh95
lib: use bracket notation instead of startsWith/endsWith for single char
b71d5de 
Signed-off-by: Taejin Kim <rlaxowls1316@naver.com>
PR-URL: #61500
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@kimtaejin3 @aduh95
lib: use bracket notation instead of startsWith/endsWith for single char
66f5d82 
Signed-off-by: Taejin Kim <rlaxowls1316@naver.com>
PR-URL: #61500
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Open
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@kimtaejin3 @aduh95
lib: use bracket notation instead of startsWith/endsWith for single char
bbd0dc4 
Signed-off-by: Taejin Kim <rlaxowls1316@naver.com>
PR-URL: #61500
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@kimtaejin3 @aduh95
lib: use bracket notation instead of startsWith/endsWith for single char
6bf8521 
Signed-off-by: Taejin Kim <rlaxowls1316@naver.com>
PR-URL: #61500
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@kimtaejin3 @trivikr @nodejs-github-bot @ljharb @lpinca @anonrig @cjihrig @bjohansebas