zlib: add CHECK to validate fast path input by mcollina · Pull Request #61175 · nodejs/node · GitHub
Skip to content

zlib: add CHECK to validate fast path input#61175

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
mcollina:fix-zlib-crc32-fast-path-validation
Dec 30, 2025
Merged

zlib: add CHECK to validate fast path input#61175
nodejs-github-bot merged 1 commit intonodejs:mainfrom
mcollina:fix-zlib-crc32-fast-path-validation

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Dec 25, 2025

Add missing CHECK in FastCRC32 to match the slow path.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Dec 25, 2025
@mcollina mcollina marked this pull request as ready for review December 25, 2025 23:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 26, 2025

Comment thread src/node_zlib.cc Outdated
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 26, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@mcollina mcollina force-pushed the fix-zlib-crc32-fast-path-validation branch from 958ba9c to c2aaa42 Compare December 27, 2025 15:19
@mcollina mcollina changed the title zlib: fix input validation in crc32 fast path zlib: add CHECK to validate fast path input Dec 27, 2025
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 29, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 29, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2025
@nodejs-github-bot nodejs-github-bot merged commit ce2ec3d into nodejs:main Dec 30, 2025
74 of 75 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

aduh95 pushed a commit that referenced this pull request Jan 9, 2026
PR-URL: #61175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 12, 2026
PR-URL: #61175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
PR-URL: #61175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 19, 2026
PR-URL: #61175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
islandryu pushed a commit to islandryu/node that referenced this pull request Jan 25, 2026
PR-URL: nodejs#61175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants