{{ message }}
build: enable maglev for Linux on s390x#60863
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Nov 28, 2025
Merged
Conversation
richardlau
added
semver-major
nodejs-github-bot
added
build
marco-ippolito
approved these changes
Nov 27, 2025
targos
approved these changes
Nov 27, 2025
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
cjihrig
approved these changes
Nov 27, 2025
richardlau
added
the
commit-queue
lpinca
approved these changes
Nov 27, 2025
jakecastelli
approved these changes
Nov 28, 2025
nodejs-github-bot
removed
the
commit-queue
Collaborator
JamieMagee
added a commit
to JamieMagee/node
that referenced
this pull request
Apr 21, 2026
V8's Maglev compiler has supported riscv64 since V8 14.0 (with full source files in deps/v8/src/maglev/riscv/), but Node.js never wired it up: - configure.py excluded riscv64 from maglev_enabled_architectures - tools/v8_gypfiles/v8.gyp lacked GN-scraper conditions for riscv64 Maglev sources in both the v8_internal_headers and v8_base_without_compiler blocks This adds riscv64 to both, following the same pattern used for s390x in nodejs#60863 and matching V8's own BUILD.gn which already lists riscv64 alongside arm, arm64, x64, s390x, and ppc64 as Maglev-enabled architectures. Refs: nodejs/build#4099 Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maglev was enabled by default for Linux on s390x in upstream V8 in 13.1 by http://crrev.com/c/5899453.
Marking as semver-major for consistency with #51360.