{{ message }}
doc: remove usage of util.inherits - #60817
Merged
Merged
Conversation
anonrig
approved these changes
Nov 23, 2025
Contributor
|
The doc part LGTM, can you remove the test change? IMO we want to validate there are no regressions on legacy APIs |
Member
Author
|
There are a specific test for this api. I had checked that . (I am on mobile I can't give the name of the test file) EDIT: file is |
Contributor
|
I would still prefer the test change gets to be discussed separately |
aymen94
approved these changes
Dec 1, 2025
Contributor
|
@AugustinMauroy can you please split the PR as requested? |
Member
Author
I'm going to do that. kind of busy |
AugustinMauroy
force-pushed
the
remove-util.inherits
branch
from
May 7, 2026 17:10
100af7f to
f3cce25
Compare
AugustinMauroy
changed the title
Member
Author
|
yup done x'D |
AugustinMauroy
force-pushed
the
remove-util.inherits
branch
from
May 7, 2026 20:11
f3cce25 to
c3bdd0d
Compare
Contributor
|
This pull request has been marked as stale due to 90 days of inactivity. |
github-actions
Bot
added
the
stale
Member
Author
|
not stale |
aduh95
approved these changes
Aug 6, 2026
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
aduh95
force-pushed
the
remove-util.inherits
branch
from
August 6, 2026 22:19
c3bdd0d to
cb31667
Compare
aduh95
added
the
author ready
github-actions
Bot
removed
the
stale
aduh95
added
doc
Contributor
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> PR-URL: #60817 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> PR-URL: #60817 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 27, 2026
Signed-off-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> PR-URL: #60817 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description