{{ message }}
tools: Update install_tools.bat old echo from 2019 to 2022#60736
Closed
Daverd-GM wants to merge 1 commit intonodejs:mainfrom
Closed
tools: Update install_tools.bat old echo from 2019 to 2022#60736Daverd-GM wants to merge 1 commit intonodejs:mainfrom
Daverd-GM wants to merge 1 commit intonodejs:mainfrom
Conversation
nodejs-github-bot
added
install
Member
Contributor
Author
|
thank's :''> I´ll do it |
Contributor
Author
|
now i did it correctly I think |
Renegade334
reviewed
Nov 16, 2025
Member
Renegade334
left a comment
Renegade334
left a comment
There was a problem hiding this comment.
This is absolutely fine, but note that you committed this in Git with an email address that doesn't match your GitHub profile, so this commit won't be linked to you. If that doesn't bother you then that's not a problem, but if you want to change this, then feel free to update your Git config and create a new commit.
Contributor
Author
|
oh that was because i did it in the git profile of my Uni mail sorry, ill fix it |
StefanStojanovic
approved these changes
Nov 17, 2025
it's a small change to update the echo accordingly to the version being installed Fixes: nodejs#60733
Contributor
Author
|
I have updated it to use the correct mail |
Renegade334
added
author ready
Renegade334
approved these changes
Nov 18, 2025
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Renegade334
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
Renegade334
added
dont-land-on-v20.x
richardlau
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/60736 ✔ Done loading data for nodejs/node/pull/60736 ----------------------------------- PR info ------------------------------------ Title tools: Update install_tools.bat old echo from 2019 to 2022 (#60736) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Daverd-GM:patch-1 -> nodejs:main Labels windows, install, tools, author ready, needs-ci, dont-land-on-v20.x Commits 1 - tools: update install_tools.bat old echo from 2019 to 2022 Committers 1 - David Hidalgo <dehidalgov+code@gmail.com> PR-URL: https://github.com/nodejs/node/pull/60736 Fixes: https://github.com/nodejs/node/issues/60733 Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60736 Fixes: https://github.com/nodejs/node/issues/60733 Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 15 Nov 2025 22:21:57 GMT ✔ Approvals: 2 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/60736#pullrequestreview-3472211695 ✔ - René (@Renegade334): https://github.com/nodejs/node/pull/60736#pullrequestreview-3475006788 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-11-18T15:35:01Z: https://ci.nodejs.org/job/node-test-pull-request/70226/ - Querying data for job/node-test-pull-request/70226/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 60736 From https://github.com/nodejs/node * branch refs/pull/60736/merge -> FETCH_HEAD ✔ Fetched commits as 0b6ae6df14ac..1c2cd05c9941 -------------------------------------------------------------------------------- [main 55dca62aea] tools: update install_tools.bat old echo from 2019 to 2022 Author: David Hidalgo <dehidalgov+code@gmail.com> Date: Mon Nov 17 19:53:48 2025 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- ✘ Git found no trailers in the original commit message, but 'Fixes: https://github.com/nodejs/node/issues/60733' is present and should be a trailer.https://github.com/nodejs/node/actions/runs/19474423133 |
Renegade334
removed
the
commit-queue-failed
Member
aduh95
added
the
dont-land-on-v22.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a small change to update the echo accordingly to the version
being installed
Sorry for the previews attempts in which i didn't follow the style
guide I panicked really with the other one I forgot the next rule
was to wrap it
Fixes: #60733