src: use string_view in `WriteReport()` by addaleax · Pull Request #60201 · nodejs/node · GitHub
Skip to content

src: use string_view in WriteReport()#60201

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
addaleax:node-report-string-conversions
Oct 12, 2025
Merged

src: use string_view in WriteReport()#60201
nodejs-github-bot merged 1 commit intonodejs:mainfrom
addaleax:node-report-string-conversions

Conversation

@addaleax
Copy link
Copy Markdown
Member

@addaleax addaleax commented Oct 10, 2025

Since 075936b, TriggerNodeReport() takes std::string_view arguments directly.

@addaleax
src: use string_view in WriteReport()
ad00d97 
Since 075936b, `TriggerNodeReport()` takes `std::string_view`
arguments directly.
@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 10, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. labels Oct 10, 2025
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 10, 2025 •
edited
Loading

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69663/

@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 10, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3ac88a7 into nodejs:main Oct 12, 2025
89 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Oct 12, 2025

@RafaelGSS RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@daeyeon daeyeon daeyeon approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@addaleax @nodejs-github-bot @lpinca @anonrig @cjihrig @richardlau @daeyeon @RaisinTen