console: allow per-stream `inspectOptions` option by addaleax · Pull Request #60082 · nodejs/node · GitHub
Skip to content

console: allow per-stream inspectOptions option#60082

Closed
addaleax wants to merge 1 commit intonodejs:mainfrom
addaleax:console-inspect-options-map
Closed

console: allow per-stream inspectOptions option#60082
addaleax wants to merge 1 commit intonodejs:mainfrom
addaleax:console-inspect-options-map

Conversation

@addaleax
Copy link
Copy Markdown
Member

@addaleax addaleax commented Oct 1, 2025

We (correctly) allow different streams to be specified for stdout and stderr, so we should also allow different inspect options for these streams.

@addaleax addaleax added semver-minor PRs that contain new features and should be released in the next minor version. console Issues and PRs related to the console subsystem. labels Oct 1, 2025
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 1, 2025
We (correctly) allow different streams to be specified for `stdout`
and `stderr`, so we should also allow different inspect options for
these streams.
@addaleax addaleax force-pushed the console-inspect-options-map branch from 24ddc86 to dc89673 Compare October 1, 2025 12:31
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 1, 2025

Comment thread lib/internal/console/constructor.js
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 2, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

addaleax added a commit that referenced this pull request Oct 3, 2025
We (correctly) allow different streams to be specified for `stdout`
and `stderr`, so we should also allow different inspect options for
these streams.

PR-URL: #60082
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
@addaleax
Copy link
Copy Markdown
Member Author

addaleax commented Oct 3, 2025

Landed in 79f1999

@addaleax addaleax closed this Oct 3, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
We (correctly) allow different streams to be specified for `stdout`
and `stderr`, so we should also allow different inspect options for
these streams.

PR-URL: #60082
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
nodejs-github-bot added a commit that referenced this pull request Oct 7, 2025
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS pushed a commit that referenced this pull request Oct 8, 2025
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) #60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) #59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) #59928

PR-URL: #60136
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
Comment thread doc/api/console.md
Comment on lines -134 to -135
* `inspectOptions` {Object} Specifies options that are passed along to
[`util.inspect()`][].
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0000

Comment on lines -142 to -145
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

Copy link
Copy Markdown

@admodius1991 admodius1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a Review

Copy link
Copy Markdown

@admodius1991 admodius1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants