inspector: add protocol methods retrieving sent/received data by legendecas · Pull Request #58645 · nodejs/node · GitHub
Skip to content

inspector: add protocol methods retrieving sent/received data#58645

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:inspector/data-sent-api
Jun 20, 2025
Merged

inspector: add protocol methods retrieving sent/received data#58645
nodejs-github-bot merged 1 commit intonodejs:mainfrom
legendecas:inspector/data-sent-api

Conversation

@legendecas
Copy link
Copy Markdown
Member

Add protocol method Network.dataSent to buffer request data. And
expose protocol methods Network.getRequestPostData and
Network.getResponseBody allowing devtool to retrieve buffered data.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 9, 2025
Add protocol method `Network.dataSent` to buffer request data. And
expose protocol methods `Network.getRequestPostData` and
`Network.getResponseBody` allowing devtool to retrieve buffered data.
@legendecas legendecas force-pushed the inspector/data-sent-api branch from 0d15711 to 5b2f8a5 Compare June 9, 2025 11:56
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Jun 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@legendecas
Copy link
Copy Markdown
Member Author

@nodejs/inspector would you mind taking a look? Thank you!

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5a14ea6 into nodejs:main Jun 20, 2025
60 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in 5a14ea6

@legendecas legendecas deleted the inspector/data-sent-api branch June 20, 2025 10:34
RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
Add protocol method `Network.dataSent` to buffer request data. And
expose protocol methods `Network.getRequestPostData` and
`Network.getResponseBody` allowing devtool to retrieve buffered data.

PR-URL: #58645
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2025
Add protocol method `Network.dataSent` to buffer request data. And
expose protocol methods `Network.getRequestPostData` and
`Network.getResponseBody` allowing devtool to retrieve buffered data.

PR-URL: #58645
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 24, 2025
Add protocol method `Network.dataSent` to buffer request data. And
expose protocol methods `Network.getRequestPostData` and
`Network.getResponseBody` allowing devtool to retrieve buffered data.

PR-URL: #58645
Reviewed-By: Ryuhei Shima <shimaryuhei@gmail.com>
@capJavert
Copy link
Copy Markdown

capJavert commented Jan 22, 2026

@legendecas sorry for tagging, but I have a question, from my usage looks like this implementation covers Network.getResponseBody on raw text response, but if body is compressed (eg. gzip, br) it shows like this in Node.js inspector network tab:
image

From my understanding we could hook into auto decompress option in http client and then use that depending on conent-encoding in getResponseBody.

Just trying to figure out if this is intended or missed?

@legendecas
Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants