src: remove unused detachArrayBuffer method by anonrig · Pull Request #58055 · nodejs/node · GitHub
Skip to content

src: remove unused detachArrayBuffer method#58055

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
anonrig:yagiz/remove-unnecessary-buffer
Apr 29, 2025
Merged

src: remove unused detachArrayBuffer method#58055
nodejs-github-bot merged 1 commit intonodejs:mainfrom
anonrig:yagiz/remove-unnecessary-buffer

Conversation

@anonrig
Copy link
Copy Markdown
Member

@anonrig anonrig commented Apr 27, 2025

Removes unused method

@anonrig anonrig requested review from jasnell and mcollina April 27, 2025 19:52
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 27, 2025
@anonrig anonrig requested a review from ronag April 27, 2025 19:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2025 •
edited
Loading

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 27, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 27, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66490/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66492/

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/66493/

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 27, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit 6876607 into nodejs:main Apr 29, 2025
77 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 29, 2025

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@anonrig @RafaelGSS
src: remove unused detachArrayBuffer method
a842a15 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@anonrig @RafaelGSS
src: remove unused detachArrayBuffer method
f7ab630 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
839afff 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
ac314da 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@anonrig @RafaelGSS
src: remove unused detachArrayBuffer method
7d352d5 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
a522e39 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
69baae2 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
fce8999 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
8772484 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
da23503 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@anonrig @aduh95
src: remove unused detachArrayBuffer method
18f5301 
PR-URL: #58055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@legendecas legendecas legendecas approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@ronag ronag Awaiting requested review from ronag

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig @nodejs-github-bot @jasnell @lpinca @legendecas