{{ message }}
Merged
Conversation
jakecastelli
added
the
fast-track
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
added
needs-ci
jakecastelli
force-pushed
the
fix-quic-debug-typos
branch
from
c7737b2 to
5eda7aa
Compare
anonrig
approved these changes
Mar 30, 2025
lpinca
approved these changes
Mar 30, 2025
bjohansebas
approved these changes
Mar 30, 2025
cjihrig
approved these changes
Mar 30, 2025
Contributor
|
I'm not sure this can currently be fast tracked because it requires a full CI run and the CI is locked down. |
Member
Author
|
oh yes, thanks for the reminder, forgot about the CI situation when I created the PR |
jakecastelli
removed
the
fast-track
benjamingr
approved these changes
Mar 31, 2025
MoLow
approved these changes
Apr 1, 2025
github-actions
Bot
removed
the
request-ci
Collaborator
Member
Well, that and quic is no longer built by default in CI ;-) |
jakecastelli
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
JonasBa
pushed a commit
to JonasBa/node
that referenced
this pull request
Apr 11, 2025
PR-URL: nodejs#57689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57689 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
added
the
dont-land-on-v20.x
aduh95
added
the
dont-land-on-v22.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.