{{ message }}
Fix sqlite custom function callback errors reporting#56773
Closed
Charlesnorris509 wants to merge 1 commit intonodejs:mainfrom
Closed
Fix sqlite custom function callback errors reporting#56773Charlesnorris509 wants to merge 1 commit intonodejs:mainfrom
Charlesnorris509 wants to merge 1 commit intonodejs:mainfrom
Conversation
Fixes nodejs#56772 Add error reporting for custom function callback errors to the sqlite API. * **src/node_sqlite.cc** - Call `sqlite3_result_error()` in `UserDefinedFunction::xFunc` when the JS callback throws an error. - Update the `retval` check to handle the error condition and call `sqlite3_result_error()`. * **test/parallel/test-sqlite-custom-functions.js** - Add a new test to verify that custom function callback errors are reported to the sqlite API. - Write tests to ensure that error conditions in the JS callback result in `sqlite3_result_error()` being called. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/nodejs/node/issues/56772?shareId=XXXX-XXXX-XXXX-XXXX).
nodejs-github-bot
added
c++
Contributor
Contributor
|
For reference, I think the fix should look more like this - cjihrig@f113c39. Note, I already had this patch mostly written when I saw your PR. |
This was referenced Jan 26, 2025
Author
|
Thanks for letting me know that this issue has been previously resolved |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56772
Add error reporting for custom function callback errors to the sqlite API.
src/node_sqlite.cc
sqlite3_result_error()inUserDefinedFunction::xFuncwhen the JS callback throws an error.retvalcheck to handle the error condition and callsqlite3_result_error().test/parallel/test-sqlite-custom-functions.js
sqlite3_result_error()being called.For more details, open the Copilot Workspace session.