fs: only show deprecation warning when error code matches by aduh95 · Pull Request #56549 · nodejs/node · GitHub
Skip to content

fs: only show deprecation warning when error code matches#56549

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:fs-existsSync-deprecation-warning
Feb 28, 2025
Merged

fs: only show deprecation warning when error code matches#56549
nodejs-github-bot merged 1 commit intonodejs:mainfrom
aduh95:fs-existsSync-deprecation-warning

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Jan 10, 2025

The deprecation is only for invalid types, it could be confusing the warning show up for an unrelated error.

Refs: #55753

@aduh95 aduh95 added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jan 10, 2025
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jan 10, 2025
BridgeAR
BridgeAR reviewed Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all Node.js errors should trigger the warning and only programmer errors in Node.js code should not be caught. Is that correct? We don't yet have such utility method to check that. We could however check for any error code existence. It should not exist on regular programmer errors.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 10, 2025 •
edited
Loading

@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Feb 26, 2025 •
edited
Loading

I believe all Node.js errors should trigger the warning and only programmer errors in Node.js code should not be caught. Is that correct? We don't yet have such utility method to check that. We could however check for any error code existence. It should not exist on regular programmer errors.

IMO that's a separate issue (IIUC you're complaining about the fact we blindly catch any error, instead of rethrowing non-Node.js ones). What this PR is addressing is that the warning should only appear when there's a ARG_TYPE error (as that's what has been deprecated).

@aduh95 aduh95 added the review wanted PRs that need reviews. label Feb 26, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 26, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 26, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65443/

bjohansebas
bjohansebas reviewed Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 27, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/65456/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 28, 2025
@nodejs-github-bot nodejs-github-bot merged commit 48f381d into nodejs:main Feb 28, 2025
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Feb 28, 2025

@aduh95 aduh95 deleted the fs-existsSync-deprecation-warning branch February 28, 2025 10:57
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@aduh95 @RafaelGSS
fs: only show deprecation warning when error code matches
cf23bb7 
PR-URL: #56549
Refs: #55753
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@aduh95 @RafaelGSS
fs: only show deprecation warning when error code matches
463e585 
PR-URL: #56549
Refs: #55753
Reviewed-By: Jacob Smith <jacob@frende.me>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
fs: only show deprecation warning when error code matches
d931914 
PR-URL: #56549
Refs: #55753
Reviewed-By: Jacob Smith <jacob@frende.me>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
fs: only show deprecation warning when error code matches
b8865df 
PR-URL: #56549
Refs: #55753
Reviewed-By: Jacob Smith <jacob@frende.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @JakobJingleheimer @BridgeAR @bjohansebas