{{ message }}
build: don't install github templates#5612
Merged
jbergstroem merged 1 commit intoMar 9, 2016
Merged
Conversation
Member
Member
|
Removing GitHub templates from the tarball change: LGTM |
Member
|
+1 to keeping CODE_OF_CONDUCT.md, COLLABORATOR_GUIDE.md, CONTRIBUTING.md and GOVERNANCE.md. The others I'm good with excluding. |
Member
Author
|
@rvagg will open open a discussion that aims to target what a tarball (vs git clone) should contain. |
Member
|
Apropos the README, people that download the binaries frequently get confused about the build instructions in it. Perhaps it's better to distribute an abridged version in release tarballs, then we can drop the other *.md files too. |
Member
Avoid putting github templates in the source tarballs. PR-URL: nodejs#5612 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
jbergstroem
force-pushed
the
fix/remove-github-templates-installer
branch
from
03940ba to
7f586c0
Compare
4 tasks
evanlucas
pushed a commit
that referenced
this pull request
Mar 14, 2016
Avoid putting github templates in the source tarballs. PR-URL: #5612 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Mar 16, 2016
Avoid putting github templates in the source tarballs. PR-URL: #5612 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Avoid putting github templates in the source tarballs. PR-URL: #5612 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2016
Avoid putting github templates in the source tarballs. PR-URL: #5612 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
build
Description of change
Avoid putting github templates in the source tarballs.
/cc @nodejs/build