- Loading data for nodejs/node/pull/55549
✔  Done loading data for nodejs/node/pull/55549
----------------------------------- PR info ------------------------------------
Title      typings: fix `ModulesBinding` types (#55549)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:module-binding-types -> nodejs:main
Labels     author ready, typings
Commits    1
 - typings: fix `ModulesBinding` types
Committers 1
 - Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/55549
Fixes: https://github.com/nodejs/node/pull/55412/files#r1817708918
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55549
Fixes: https://github.com/nodejs/node/pull/55412/files#r1817708918
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 26 Oct 2024 09:16:11 GMT
   ✔  Approvals: 2
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/55549#pullrequestreview-2397109686
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/55549#pullrequestreview-2411266335
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   10cce655ca..c0db893f04  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 13577d3dbc module: simplify `findPackageJSON` implementation
 - c0db893f04 module: simplify `findPackageJSON` implementation
--------------------------------------------------------------------------------
HEAD is now at c0db893f04 module: simplify `findPackageJSON` implementation
   ✔  Reset to origin/main
- Downloading patch for 55549
From https://github.com/nodejs/node
 * branch                  refs/pull/55549/merge -> FETCH_HEAD
✔  Fetched commits as c0db893f04f4..37f0f77f3099
--------------------------------------------------------------------------------
[main 9ebf2997f9] typings: fix `ModulesBinding` types
 Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
 Date: Sat Oct 26 11:15:04 2024 +0200
 1 file changed, 5 insertions(+), 4 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
typings: fix `ModulesBinding` types
PR-URL: #55549

Fixes: https://github.com/nodejs/node/pull/55412/files#r1817708918

Reviewed-By: Jacob Smith <jacob@frende.me>

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
[main 6f2c4bc3b9] typings: fix ModulesBinding types

Author: Antoine du Hamel <duhamelantoine1995@gmail.com>

Date: Sat Oct 26 11:15:04 2024 +0200

1 file changed, 5 insertions(+), 4 deletions(-)

✖  6f2c4bc3b9e175de91f7841992133206dc56b89d

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✖  2:7      Fixes must be a GitHub URL.               fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue