{{ message }}
doc: updated the Class:fs filesystem documentation as it was missing …#55279
Closed
shrenisc wants to merge 9 commits into
Closed
doc: updated the Class:fs filesystem documentation as it was missing …#55279shrenisc wants to merge 9 commits into
shrenisc wants to merge 9 commits into
Conversation
…information and examples Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Cleared the air on why statfs.type returns a int|bigint value. Fixes: #50749
nodejs-github-bot
added
doc
avivkeller
reviewed
Oct 5, 2024
Comment on lines
+7660
to
+7748
Member
There was a problem hiding this comment.
Instead of a table, is there a wikipage or something that users can be referred to?
Author
There was a problem hiding this comment.
I found a Linux Manual page which lists these filesystems but I am unsure whether we can link it here. Also, they only list Linux filesystems and miss out on the popular NTFS, NFS etc.
Member
|
Can you fix your commit message? Something like:
|
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
…information and examples Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Cleared the air on why statfs.type returns a int|bigint value. Fixes: #50749
avivkeller
reviewed
Oct 5, 2024
…into statfs_docs_update
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used filesystems and their magic numbers. Fixes: #50749
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems. Fixes: #50749
Co-authored-by: Aviv Keller <redyetidev@gmail.com>
Member
|
It looks like your merge caused some errors. Please remove the merge commit. |
Author
|
Hi, could I know what errors were caused? This is my first time submitting
a PR, so I'm not familiar with the working.
Thank you.
…On Sun, 6 Oct, 2024, 3:08 am Aviv Keller, ***@***.***> wrote:
It looks like your merge caused some errors. Please remove the merge
commit.
—
Reply to this email directly, view it on GitHub
<#55279 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV4KZFMJPDGP3VYPQTD2TLDZ2BL7DAVCNFSM6AAAAABPNJ3YCCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGIYDIMZQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined the return type for statfs.bsize. Added examples for statfs.bavail, statfs.bfree, statfs.blocks and statfs.files for clarity. Explained why statfs.type returns a int|bigint value and added a table with most commonly used magic numbers and their filesystems.
Fixes: #50749