quic: address recent coverity warnings by mhdawson · Pull Request #52647 · nodejs/node · GitHub
Skip to content

quic: address recent coverity warnings#52647

Closed
mhdawson wants to merge 1 commit intonodejs:mainfrom
mhdawson:coverity-50
Closed

quic: address recent coverity warnings#52647
mhdawson wants to merge 1 commit intonodejs:mainfrom
mhdawson:coverity-50

Conversation

@mhdawson
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels Apr 22, 2024
@mhdawson
Copy link
Copy Markdown
Member Author

@mhdawson
Copy link
Copy Markdown
Member Author

@nodejs/quic FYI

Copy link
Copy Markdown
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoroz
Copy link
Copy Markdown
Member

vmoroz commented Apr 22, 2024

Currently quic cctest is failing on Windows. Hopefully this PR must fix them.

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2024
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

mhdawson added a commit that referenced this pull request Apr 29, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mhdawson
Copy link
Copy Markdown
Member Author

@mhdawson mhdawson closed this Apr 29, 2024
aduh95 pushed a commit that referenced this pull request Apr 30, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolito marco-ippolito added backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. and removed backport-blocked-v20.x PRs that should land on the v20.x-staging branch but are blocked by another PR's pending backport. labels May 21, 2024
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#52647
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants