{{ message }}
[v20.x backport] win,tools: upgrade Windows signing to smctl#51116
Closed
StefanStojanovic wants to merge 1 commit intonodejs:v20.x-stagingfrom
Closed
[v20.x backport] win,tools: upgrade Windows signing to smctl#51116StefanStojanovic wants to merge 1 commit intonodejs:v20.x-stagingfrom
StefanStojanovic wants to merge 1 commit intonodejs:v20.x-stagingfrom
Conversation
As a part of the new signing requrements for Windows change approach to use the DigiCert cloud HSM service KeyLocker. PR-URL: nodejs#50956 Fixes: nodejs/build#3491 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs-github-bot
added
needs-ci
StefanStojanovic
changed the title
richardlau
approved these changes
Dec 11, 2023
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
@nodejs/releasers It's possible the original commit will cherry-pick cleanly but I'm approving this backport in case it doesn't and we need to land before the usual "two weeks in current".
Please note that the Windows signing certificate we have been using expires on 18 December 2023 (nodejs/build#3491) so any new releases should include this PR so that they start using the new certificate.
Contributor
Author
UlisesGascon
force-pushed
the
v20.x-staging
branch
from
423c757 to
fd4149d
Compare
Merged
UlisesGascon
force-pushed
the
v20.x-staging
branch
2 times, most recently
from
4c9099f to
7af8e20
Compare
UlisesGascon
force-pushed
the
v20.x-staging
branch
from
a42629c to
435f9c9
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a part of the new signing requirements for Windows, this changes the approach to using the DigiCert cloud HSM service KeyLocker. This change already landed on the main branch in this PR. This is just a port to the LTS version needed for future releases.
Refs: nodejs/build#3491