{{ message }}
esm: spawn only one hooks thread#50752
Closed
GeoffreyBooth wants to merge 1 commit into
Closed
Conversation
aduh95
reviewed
Dec 1, 2023
aduh95
reviewed
Dec 1, 2023
d145830 to
28a5bc5
Compare
28a5bc5 to
3bad36e
Compare
3bad36e to
4480771
Compare
Member
6 tasks
Member
Author
|
Fixed by #52706 |
This was referenced May 22, 2024
This was referenced May 30, 2024
This was referenced Jun 12, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Our intent with moving module customization hooks into a separate thread was that one such “hooks thread” would be spawned regardless of however many worker threads the user’s application code spawned. On current
mainthis is not the case; a new hooks thread is created alongside each new worker thread.This PR aims to fix that, but currently all I have is a test that fails on current
mainbut should pass, once this bug is fixed. I’m opening this as a placeholder for when a fix is ready, and I encourage anyone who wants to take a crack at it to help make this test pass. I’m happy to let others push commits on my branch.cc @nodejs/loaders @nodejs/workers