tools, test: enable space-in-parens ESLint rule by silverwind · Pull Request #4753 · nodejs/node · GitHub
Skip to content

tools, test: enable space-in-parens ESLint rule #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
silverwind wants to merge 2 commits into from
Closed

tools, test: enable space-in-parens ESLint rule #4753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d908ecf
tools: enable space-in-parens ESLint rule
silverwind Jan 19, 2016
f9efb7a
test: fix issues for space-in-parens ESLint rule
silverwind Jan 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc
View file
Open in desktop
2 changes: 1 addition & 1 deletion test/parallel/test-beforeexit-event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ var common = require('../common');
var revivals = 0;
var deaths = 0;

process.on('beforeExit', function() { deaths++; } );
process.on('beforeExit', function() { deaths++; });

process.once('beforeExit', tryImmediate);

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-crypto-hmac.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ var wikipedia = [
for (var i = 0, l = wikipedia.length; i < l; i++) {
for (var hash in wikipedia[i]['hmac']) {
// FIPS does not support MD5.
if (common.hasFipsCrypto && hash == 'md5' )
if (common.hasFipsCrypto && hash == 'md5')
continue;
var result = crypto.createHmac(hash, wikipedia[i]['key'])
.update(wikipedia[i]['data'])
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http-client-timeout-agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ var options = {
var server = http.createServer(function(req, res) {
const m = /\/(.*)/.exec(req.url);
const reqid = parseInt(m[1], 10);
if ( reqid % 2 ) {
if (reqid % 2) {
// do not reply the request
} else {
res.writeHead(200, {'Content-Type': 'text/plain'});
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-process-binding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ assert.throws(
assert.doesNotThrow(function() {
process.binding('buffer');
}, function(err) {
if ( (err instanceof Error) ) {
if (err instanceof Error) {
return true;
}
}, 'unexpected error');
2 changes: 1 addition & 1 deletion test/pummel/test-timers.js
View file
Open in desktop