{{ message }}
[v16.x] src,doc,test: add --openssl-shared-config option#43783
Closed
RafaelGSS wants to merge 1 commit intonodejs:v16.x-stagingfrom
Closed
[v16.x] src,doc,test: add --openssl-shared-config option#43783RafaelGSS wants to merge 1 commit intonodejs:v16.x-stagingfrom
RafaelGSS wants to merge 1 commit intonodejs:v16.x-stagingfrom
Conversation
Collaborator
nodejs-github-bot
added
c++
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: nodejs#43124 Refs: nodejs#40366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
RafaelGSS
force-pushed
the
backport-43124-v16-cli
branch
from
7399ebe to
ecdead2
Compare
github-actions
Bot
removed
the
request-ci
Collaborator
BethGriggs
approved these changes
Jul 13, 2022
richardlau
approved these changes
Jul 13, 2022
Collaborator
29 tasks
Collaborator
24 tasks
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
Member
|
I'm sorry, there is now a conflict with other commits that landed on v16.x-staging. Could you please update the backport? I noted that in the original change, the flag only exists if |
Member
Author
Yes, it was added this way because the initial idea was to support v17.x > only, but we need the revert flag in other release lines as well. Thanks for notifying me, I'll rebase |
Member
Author
This was referenced Jul 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was forgotten in: #43545
Ref: nodejs/nodejs.org#4713
This commit adds a new command line option named
'--openssl-shared-config' intended to allow reverting to the old OpenSSL
configuration behavior where Node.js would use the configuration section
name (called appname in OpenSSL) 'openssl_conf' which could potentially
be used my other applications..
PR-URL: #43124
Refs: #40366
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Rich Trott rtrott@gmail.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com
Reviewed-By: Beth Griggs bgriggs@redhat.com