url: revert "validate ipv4 part length"#42940
Conversation
This reverts commit 87d0d7a. Refs: nodejs#42915
targos
left a comment
There was a problem hiding this comment.
Don't we usually keep the revert message created by Git?
Our release tooling does have special treatment for the standard git revert message format. I’d rather edit our commit message guidelines to reflect that than ignore it 🙂 e.g. https://github.com/nodejs/node/blob/1d8a320a04d75b2143be0bc97b10dfcd9e64defa/doc/changelogs/CHANGELOG_V16.md#commits-3 contains
|
|
Since this is a revert, is it reasonable to fast-track so it can be included in the 3rd May builds? |
This PR and the on it reverts has the https://github.com/nodejs/node/labels/dont-land-on-v18.x, so none will be included on May 3rd release anyway :) |

This reverts commit 87d0d7a.
Refs: #42915 (comment)