{{ message }}
test: use conventional argument order in assertion#40591
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
test: use conventional argument order in assertion#40591tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Oct 24, 2021
VoltrexKeyva
approved these changes
Oct 25, 2021
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Oct 25, 2021
This comment has been minimized.
This comment has been minimized.
VoltrexKeyva
added
request-ci
Trott
added
the
author ready
targos
approved these changes
Oct 25, 2021
lpinca
approved these changes
Oct 25, 2021
github-actions
Bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
25 tasks
This comment has been minimized.
This comment has been minimized.
trivikr
approved these changes
Oct 26, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
26 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
30 tasks
BridgeAR
approved these changes
Oct 28, 2021
jasnell
approved these changes
Oct 28, 2021
jasnell
added
the
commit-queue
Collaborator
github-actions
Bot
added
commit-queue-failed
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/40591 ✔ Done loading data for nodejs/node/pull/40591 ----------------------------------- PR info ------------------------------------ Title test: use conventional argument order in assertion (#40591) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:test-buffer-fill-actual-expected-order -> nodejs:master Labels test, author ready Commits 1 - test: use conventional argument order in assertion Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/40591 Reviewed-By: Colin Ihrig Reviewed-By: Voltrex Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40591 Reviewed-By: Colin Ihrig Reviewed-By: Voltrex Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca Reviewed-By: Trivikram Kamat Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 24 Oct 2021 21:58:40 GMT ✔ Approvals: 8 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40591#pullrequestreview-787557451 ✔ - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40591#pullrequestreview-787572367 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40591#pullrequestreview-787614687 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40591#pullrequestreview-787647207 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40591#pullrequestreview-787657637 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/40591#pullrequestreview-789555558 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/40591#pullrequestreview-791762513 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40591#pullrequestreview-791932157 ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-10-28T14:13:33Z: https://ci.nodejs.org/job/node-test-pull-request/40528/ - Querying data for job/node-test-pull-request/40528/ ✔ Build data downloaded - Querying failures of job/node-test-commit/49509/ ✔ Data downloaded ✖ 2 failure(s) on the last Jenkins CI run -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1395092374 |
VoltrexKeyva
pushed a commit
that referenced
this pull request
Oct 28, 2021
PR-URL: #40591 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Landed in f7209ee |
Member
|
@VoltrexMaster Please in the future do not land PRs with failing CI. In this particular case it's not worth reverting the land. |
Contributor
Sorry, sometimes we land PRs without them fully passing the CI after many tries, not entirely sure if there was any problem landing this particular PR in this case, but will look forward to them fully passing it in the future. 😅 |
Member
This was referenced Oct 29, 2021
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40591 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40591 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By convention (and per the names of the arguments), the expected value should be the second argument.