{{ message }}
doc: update buffer.constants.MAX_LENGTH#38109
Closed
Ayase-252 wants to merge 4 commits intonodejs:masterfrom
Closed
doc: update buffer.constants.MAX_LENGTH#38109Ayase-252 wants to merge 4 commits intonodejs:masterfrom
buffer.constants.MAX_LENGTH#38109Ayase-252 wants to merge 4 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
buffer
RaisinTen
reviewed
Apr 6, 2021
aduh95
reviewed
Apr 6, 2021
RaisinTen
approved these changes
Apr 7, 2021
Member
Author
aduh95
approved these changes
Apr 7, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
LGTM with or without my suggestions.
aduh95
approved these changes
Apr 8, 2021
RaisinTen
added
the
author ready
Member
Do you already know it won't land cleanly, or does it need to be adapted for the state of v14.x? |
Contributor
@targos the value is different in v15.x and v14.x, I believe a manual backport is necessary to adjust the value on the v14.x branch. Maybe a |
jasnell
approved these changes
Apr 12, 2021
Member
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 13, 2021
Fixes: nodejs#38093 PR-URL: nodejs#38109 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 13, 2021
Fixes: nodejs#38093 PR-URL: nodejs#38109 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#38232
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 13, 2021
Fixes: nodejs#38093 PR-URL: nodejs#38109 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#38232
juanarbol
pushed a commit
to juanarbol/node
that referenced
this pull request
Apr 20, 2021
Fixes: nodejs#38093 PR-URL: nodejs#38109 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Backport-PR-URL: nodejs#38232
targos
added
backported-to-v14.x
and removed
backport-requested-v14.x
author ready
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
buffer.constants.MAX_LENGTHfor different Node.js versions in 64-bit platform;v8::TypedArray::kMaxLengthas an informative note.Fixes: #38093