fix comment by angrymouse · Pull Request #35913 · nodejs/node · GitHub
Skip to content

fix comment#35913

Closed
angrymouse wants to merge 1 commit into
nodejs:masterfrom
angrymouse:patch-1
Closed

fix comment#35913
angrymouse wants to merge 1 commit into
nodejs:masterfrom
angrymouse:patch-1

Conversation

@angrymouse

@angrymouse angrymouse commented Nov 1, 2020

Copy link
Copy Markdown
Contributor

Fixed incorrect path in comment for posix.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Nov 1, 2020

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the result on my machine:

$ node -p "path.posix.basename('/tmp/myfile.html')"
myfile.html

@aduh95

aduh95 commented Nov 1, 2020

Copy link
Copy Markdown
Contributor

@Trott Trott closed this Nov 2, 2020
@Trott Trott added the invalid Issues and PRs that are invalid. label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. invalid Issues and PRs that are invalid. path Issues and PRs related to the path subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants