{{ message }}
doc: add missing copyFile change history#35056
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
doc
codebytere
force-pushed
the
add-flags-history
branch
from
f4f3270 to
a6b561f
Compare
mscdex
reviewed
Sep 4, 2020
Contributor
codebytere
force-pushed
the
add-flags-history
branch
from
a6b561f to
155c467
Compare
Member
Author
|
@mscdex i don't feel terribly strongly about the name change i suppose, but i think it's helpful for users who may wonder why references to a parameter have changed. In the interest of ensuring that the barriers to effective documentation grokking remain low, i think there is value in minimizing potential sources of confusion. |
Trott
approved these changes
Sep 6, 2020
Member
|
I don't mind erring on the side of over-communicating in the change-logging YAML stuff, especially since the material is hidden by default in the rendered HTML docs. |
codebytere
added
the
author ready
Member
Author
codebytere
added a commit
that referenced
this pull request
Sep 14, 2020
PR-URL: #35056 Reviewed-By: Rich Trott <rtrott@gmail.com>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 17, 2020
PR-URL: #35056 Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
PR-URL: #35056 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35056 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered when working to upgrade Electron to Node.js v14.x - the changes in #27044 were
semver-majorand thus should likely be added into the change history for those methods.cc @BridgeAR
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes