CI: https://ci.nodejs.org/job/node-test-pull-request/32011/

On a related note, is there a reason why we aren't running make test-benchmark in CI to prevent issues like this? I thought benchmark tests used to be run along with all of the normal tests?

/cc @nodejs/collaborators

On a related note, is there a reason why we aren't running make test-benchmark in CI to prevent issues like this? I thought benchmark tests used to be run along with all of the normal tests?

/cc @nodejs/collaborators

People complained that they took too long and timed out too much, so we moved them to node-daily-master. I wouldn't be opposed to adding them back to regular CI runs if we can get regular CI to be less unreliable. The current situation is pretty bad.

I suggest to run the benchmark tests on our CI but not locally.

People complained that they took too long and timed out too much, so we moved them to node-daily-master. I wouldn't be opposed to adding them back to regular CI runs if we can get regular CI to be less unreliable. The current situation is pretty bad.

As far as I can tell, the node-daily-master CI job isn't currently failing on the EventTarget benchmark like it should be. Does anyone regularly check/monitor the results of node-daily-master?

Benchmark CI as a test: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/621/

@mscdex ... I pulled this commit into #34015 so that we can land a batch of the eventtarget related items at once. Do you mind if we close this one in favor of that?

As far as I can tell, the node-daily-master CI job isn't currently failing on the EventTarget benchmark like it should be. Does anyone regularly check/monitor the results of node-daily-master?

I check it every day. (Sam Roberts did for a while too, but I think he stopped checking a week or three ago.) However I have not had the time to follow up on the various issues. I just see what's failing, feel a pang of guilt that I don't have time to dig in on it right now, and move on. It's my once-a-day guilt-shot.