errors: replace manual sep code with path.sep by MylesBorins · Pull Request #32440 · nodejs/node · GitHub
Skip to content

errors: replace manual sep code with path.sep#32440

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:errors-path-sep
Closed

errors: replace manual sep code with path.sep#32440
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:errors-path-sep

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Mar 23, 2020
@ljharb

ljharb commented Mar 23, 2020

Copy link
Copy Markdown
Member

@MylesBorins

Copy link
Copy Markdown
Contributor Author

There is a circular reference here causing a problem

TypeError: Cannot destructure property 'ERR_INVALID_ARG_TYPE' of 'require(...).codes' as it is undefined.

@MylesBorins

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

errors Issues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants