{{ message }}
src: fix warn_unused_result compiler warning#32241
Merged
Merged
Conversation
nodejs-github-bot
added
c++
Contributor
sam-github
approved these changes
Mar 13, 2020
devnexen
approved these changes
Mar 13, 2020
addaleax
requested changes
Mar 13, 2020
Member
|
@sam-github One problem with |
Contributor
|
It could, but then we would see, and fix it, as opposed to people later noticing and there being a stream (ok, continuous trickle?) of PRs to fix the warnings. I don't think we've a situation where there is a warning that can't be fixed across gcc* and clang*. I have in the past worked on multi-platform code where it wasn't possible to make code that satisfied all our compilers simultaneously, but I think clang and gcc are under some kind of social or technical pressure to not diverge like that. |
addaleax
approved these changes
Mar 13, 2020
addaleax
added
the
author ready
Collaborator
jasnell
approved these changes
Mar 13, 2020
Collaborator
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: nodejs#32241 Refs: nodejs#31972 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
BridgeAR
pushed a commit
that referenced
this pull request
Mar 17, 2020
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: #32241 Refs: #31972 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 24, 2020
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: #32241 Refs: #31972 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: #32241 Refs: #31972 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #31972
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes