{{ message }}
stream: avoid destroying http1 objects#32197
Closed
ronag wants to merge 3 commits into
Closed
Conversation
Member
Author
addaleax
approved these changes
Mar 11, 2020
Collaborator
Member
|
@ronag are we sure we should not revert all of those fixes instead and redo a PR with all of them? |
Member
Author
I would prefer not. Seems more difficult than fixing it. I see your point though. If you would prefer revert I would be ok with that. |
Member
|
Let's see if something else pop up. |
ronag
force-pushed
the
pipeline-fix-destroyer
branch
2 times, most recently
from
5aeab8d to
abd091c
Compare
Collaborator
ronag
added
the
author ready
BridgeAR
reviewed
Mar 11, 2020
MylesBorins
added
the
fast-track
Contributor
|
can we fast track this? I'd like to see it land in the upcoming 13.11.0 release @ronag looks like this needs a rebase |
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: nodejs#32184
ronag
force-pushed
the
pipeline-fix-destroyer
branch
from
d83675f to
1415464
Compare
Member
Author
|
rebased @MylesBorins |
Collaborator
Member
|
+1 to fast track |
Contributor
|
@ronag FWIW this patch is not going to land cleanly on v13.x. You might want to get started on a backport now if you have time. very much trying to get this out in today's release. |
4 tasks
Contributor
MylesBorins
pushed a commit
that referenced
this pull request
Mar 11, 2020
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: #32184 PR-URL: #32197 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 12, 2020
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: #32184 Backport-PR-URL: #32212 PR-URL: #32197 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http1 objects are coupled with their corresponding
res/req and cannot be treated independently as
normal streams. Add a special exception for this
in the pipeline cleanup.
Fixes: #32184
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes